Re: [PATCH] Fix bad usage of mkpath in builtin-branch.sh

From: Junio C Hamano <junkio@cox.net>
Date: Oct 25, 2006, 04:00 UTC
Message-ID: <7vac3lf3jl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061024113806.GB20017@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

Show 15 quoted lines

> Dear diary, on Tue, Oct 24, 2006 at 08:46:49AM CEST, I got a letter
> where Junio C Hamano <junkio@cox.net> said that...
>> Lars Hjemli <hjemli@gmail.com> writes:
>> 
>> > diff --git a/builtin-branch.c b/builtin-branch.c
>> > index ffc2db0..f86bf68 100755
>> 
>> I've already fixed up this perm-mode breakage (and other
>> breakages, possibly) so when I am done with these patches
>> tonight please resync with me.
>
> I have made my fair share of inadverent mode changes as well (I don't
> even know how that *happenned*), and I don't seem to be alone; since
> this is something you are doing only rarely anyway, perhaps we should
> try to make mode changes more visible?

Well we already do and that's how I noticed.