Re: [PATCH] Fix bad usage of mkpath in builtin-branch.sh

From: Petr Baudis <pasky@suse.cz>
Date: Oct 24, 2006, 11:38 UTC
Message-ID: <20061024113806.GB20017@pasky.or.cz>
In-Reply-To: <7vlkn6qkh2.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, Oct 24, 2006 at 08:46:49AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 19 quoted lines

> Lars Hjemli <hjemli@gmail.com> writes:
> 
> > When checking if a branch start point referred to a commit-object,
> > the result of mkpath() was used as argument to get_sha1(), which
> > didn't work out as planned.
> >
> > Now it's xstrdup'd first.
> >
> > Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> > ---
> >  builtin-branch.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/builtin-branch.c b/builtin-branch.c
> > index ffc2db0..f86bf68 100755
> 
> I've already fixed up this perm-mode breakage (and other
> breakages, possibly) so when I am done with these patches
> tonight please resync with me.

I have made my fair share of inadverent mode changes as well (I don't even know how that *happenned*), and I don't seem to be alone; since this is something you are doing only rarely anyway, perhaps we should try to make mode changes more visible?

	@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
	@ WARNING: FILE MODE HAS CHANGED!!!!111 pERHAPS A MISTAKE? @
	@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

;-))

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)