Re: [PATCH] Fix bad usage of mkpath in builtin-branch.sh

From: Petr Baudis <pasky@suse.cz>
Date: Oct 25, 2006, 22:43 UTC
Message-ID: <20061025224313.GM20017@pasky.or.cz>
In-Reply-To: <7vslhddmtu.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Wed, Oct 25, 2006 at 06:46:37AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 26 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
> 
> > Petr Baudis <pasky@suse.cz> writes:
> >
> >> I have made my fair share of inadverent mode changes as well (I don't
> >> even know how that *happenned*), and I don't seem to be alone; since
> >> this is something you are doing only rarely anyway, perhaps we should
> >> try to make mode changes more visible?
> >
> > Well we already do and that's how I noticed.
> 
> Ah, sorry, I think I misunderstood you.
> Did you mean something like this?
> 
> diff --git a/git-commit.sh b/git-commit.sh
> index 5b1cf85..8bae734 100755
> --- a/git-commit.sh
> +++ b/git-commit.sh
> @@ -629,4 +629,7 @@ if test -x "$GIT_DIR"/hooks/post-commit
>  then
>  	"$GIT_DIR"/hooks/post-commit
>  fi
> +
> +test "$ret" = 0 && git-diff-tree --summary --root --no-commit-id HEAD
> +
>  exit "$ret"

Yes, this might be a good idea, although after the commit is perhaps too late.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1