Re: [PATCH] Simplify MSGFMT setting in Makefile

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 14, 2008, 04:50 UTC
Message-ID: <7vabl1vrh7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <18394.671.630499.836160@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> I have a few commits for you to pull, but I am about to push a patch
> for gitk like the one you sent for git-gui, so I'll send you a pull
> request when I've done that.

Thanks.

Show 6 quoted lines

>>  else
>>  	MSGFMT ?= msgfmt
>> -	ifeq ($(shell $(MSGFMT) >/dev/null 2>&1 || echo $$?),127)
>> +	ifneq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null; echo $?),0)
>
> I had to put "echo $$?" for it to work rather than "echo $?".

Yeah, very sorry about this; Shawn already has pointed it out to me.