Re: [PATCH] Simplify MSGFMT setting in Makefile

From: Paul Mackerras <paulus@samba.org>
Date: Mar 14, 2008, 04:44 UTC
Message-ID: <18394.671.630499.836160@cargo.ozlabs.ibm.com>
In-Reply-To: <7vr6eg7bn3.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano writes:

>  * I am planning to close 'master' for -rc1 by the end of this week, so
>    please plan to tell me to pull if you have accumulated changes,
>    thanks.

I have a few commits for you to pull, but I am about to push a patch for gitk like the one you sent for git-gui, so I'll send you a pull request when I've done that. However, I found that in this line:

>  else
>  	MSGFMT ?= msgfmt
> -	ifeq ($(shell $(MSGFMT) >/dev/null 2>&1 || echo $$?),127)
> +	ifneq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null; echo $?),0)

I had to put "echo $$?" for it to work rather than "echo $?".

Paul.