git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Simplify MSGFMT setting in Makefile

From
Charles Bailey <charles@hashpling.org>
Date
Mar 12, 2008, 10:19 UTC
Message-ID
<20080312101912.GB5530@hashpling.org>
In-Reply-To
<7vr6eg7bn3.fsf_-_@gitster.siamese.dyndns.org>
On Tue, Mar 11, 2008 at 10:29:52PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> To prepare msg files for Tcl scripts, the command that is set to MSGFMT
> make variable needs to be able to grok "--tcl -l <lang> -d <here>" options
> correctly.  This patch simplifies the tests done in git-gui's Makefile to
> directly test this condition.  If the test run does not exit properly with
> zero status (either because you do not have "msgfmt" itself, or your
> "msgfmt" is too old to grok --tcl option --- the reason does not matter),
> have it fall back to po/po2msg.sh
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Tested-by: Charles Bailey <charles@hashpling.org>

This looks good to me on Mac OS X 10.5.2, would anyone like me to prepare a patch for gitk as without it we still need to manually specifiy NO_MSGFMT to the top level git make in any case?

Charles.
Previous: Shawn O. PearceNext: Paul Mackerras
Message 18 of 21 in “msgmft segfaulting on tiger”
  1. Martin LanghoffFeb 21, 2008
  2. Martin LanghoffFeb 21, 2008
  3. Shawn O. PearceFeb 22, 2008
  4. Martin LanghoffFeb 22, 2008
  5. Gabriel SaldañaFeb 27, 2008
  6. Johannes SchindelinFeb 27, 2008
  7. Gabriel SaldañaFeb 27, 2008
  8. Johannes SchindelinFeb 27, 2008
  9. Junio C HamanoFeb 27, 2008
  10. Shawn O. PearceFeb 28, 2008
  11. msgmft segfaulting on ubuntu gutsy (clean)Gabriel Saldaña, Mar 4, 2008
  12. Shawn O. PearceMar 4, 2008
  13. Gabriel SaldañaFeb 28, 2008
  14. Shawn O. PearceMar 5, 2008
  15. Junio C HamanoMar 6, 2008
  16. Simplify MSGFMT setting in MakefileJunio C Hamano, Mar 12, 2008
  17. Shawn O. PearceMar 12, 2008
  18. Charles BaileyMar 12, 2008
  19. Paul MackerrasMar 14, 2008
  20. Junio C HamanoMar 14, 2008
  21. Andreas EricssonMar 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.