git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG?] "git rebase --interactive" forces me to edit message.

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 7, 2008, 06:53 UTC
Message-ID
<7vabhxpwgv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0806070556030.1783@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 11 quoted lines
>> But I started wondering (especially after read Junio's example) if you 
>> might have to stop and force edit the message even for commits you 
>> "pick", once you have a conflict.  The patch might not conflict, but 
>> with your logic shouldn't you be given a chance to amend messages, now 
>> it was discovered that the upstream did change that overlaps what you 
>> did?
>
> You do.  With a conflict, it stops.  If you do not commit, but only 
> resolve the conflicts and add them to the index, then continue the rebase 
> -i, it will ask you to commit.  Interactively.  (IOW an editor is fired 
> up.)
I might be misreading it, but my understanding of the scenario is:
 - you have pick A, pick B and pick C;
 - you reordered them to pick C, pick B and pick A;
 - the first one, pick C failed, and "add -u && rebase --continue" does
   ask for that pick C.

However, if neither pick B and pick A after that step has textual conflicts, the command does not stop for them, and does not give you a chance to adjust their potentially stale commit log messages.

I've already stated my position on this issue earlier in the thread.
Previous: Johannes Schindelin
Message 8 of 8 in “[BUG?] "git rebase --interactive" forces me to edit message.”
  1. しらいしななこJun 5, 2008
  2. Junio C HamanoJun 5, 2008
  3. Johannes SchindelinJun 5, 2008
  4. Johannes SchindelinJun 5, 2008
  5. しらいしななこJun 6, 2008
  6. Junio C HamanoJun 6, 2008
  7. Johannes SchindelinJun 7, 2008
  8. Junio C HamanoJun 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.