git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG?] "git rebase --interactive" forces me to edit message.

From
しらいしななこ <nanako3@bluebottle.com>
Date
Jun 6, 2008, 21:46 UTC
Message-ID
<200806062147.m56LlCOd030269@mi0.bluebottle.com>
In-Reply-To
<alpine.DEB.1.00.0806050536380.21190@racer>
Quoting Johannes Schindelin <Johannes.Schindelin@gmx.de>:
Show 24 quoted lines
> Hi,
>
> On Thu, 5 Jun 2008, しらいしななこ wrote:
>
>> When an interactive rebase stops because of conflicts in a commit marked 
>> with pick, the user must edit the file to resolve them, run "git add", 
>> and run "git rebase --continue".  It then opens vi and asks the user to 
>> edit the message.  If I told the command to edit, I think it is OK to 
>> start vi, but when I am just picking the commit, I should be able to use 
>> the message from the original commit without having to view nor edit nor 
>> save it first. Is this a bug?
>
> No, it is intentional.
>
> If you have to edit, because of conflicts, it may be because _part_ of the 
> commit ended up in upstream already.
>
> To remind the user that the commit message may need to be adjusted, rebase 
> --interactive fires up the editor.
>
> Yes, it happened to me.  Yes, the reminder was helpful.
>
> Hth,
> Dscho
Thank you very much.  I think I understand the problem better with your explanation (and much more detailed explanation from Junio).
But I started wondering (especially after read Junio's example) if you might have to stop and force edit the message even for commits you "pick", once you have a conflict.  The patch might not conflict, but  with your logic shouldn't you be given a chance to amend messages, now it was discovered that the upstream did change that overlaps what you did?
-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

----------------------------------------------------------------------
Finally - A spam blocker that actually works.
http://www.bluebottle.com/tag/4
Previous: Johannes SchindelinNext: Junio C Hamano
Message 5 of 8 in “[BUG?] "git rebase --interactive" forces me to edit message.”
  1. しらいしななこJun 5, 2008
  2. Junio C HamanoJun 5, 2008
  3. Johannes SchindelinJun 5, 2008
  4. Johannes SchindelinJun 5, 2008
  5. しらいしななこJun 6, 2008
  6. Junio C HamanoJun 6, 2008
  7. Johannes SchindelinJun 7, 2008
  8. Junio C HamanoJun 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.