Re: [PATCHv2] add Android support

Rafael Gieschke <rafael@gieschke.de> writes:

Whoa, whoa, wait. That's doing too many things in one patch.

I am still debating myself if this rather huge patch is justifiable, or an elaborate joke/hoax. Does anybody seriously want to run git on his phone, tablet or set-top box?

I'd suggest splitting it into three patch series, and justify them separately.

 (1) Support NO_GECOS_IN_PWENT (Makefile, ident.c);
 (2) Support NO_GETPASS (Makefile, compat/getpass.c, git-compat-util.h); and
 (3) Add uname_S = Android (Makefile).

The first two would become much easier to justify if presented that way. At least you won't hear from anybody "we don't want that much code to not to run git on a phone!", as it is not entirely implausible to imagine environments without support for one or both of these two facilities.

I wonder if you want to emply the rename trick similar to the one used for hstrerror/githstrerror you can see in the git-compat-util.h header file in the second step, though.

Thanks.