Re: Cross-compiling git (was: [PATCHv2] add Android support)

From: Jeff King <peff@peff.net>
Date: May 25, 2011, 15:06 UTC
Message-ID: <20110525150655.GA8795@sigill.intra.peff.net>
In-Reply-To: <201105251620.01116.jnareb@gmail.com>

On Wed, May 25, 2011 at 04:20:00PM +0200, Jakub Narebski wrote:

> Well, the vague sketch of an idea is for Makefile to set uname_*
> variables depending on the contents of `host` / `HOST` build variable,
> so that detection is based on the target OS.

Right. But my point is that there is no uname_* variable that corresponds to Android (at least from me running "uname" on the one Android device I have access to). You need a new variable.

> > Whether you call it "ANDROID=YesPlease" or some other form.
> 
> I think it is better to solve more generic issue of cross-compiling
> Git rather than solving narrow issue of cross-compiling Git on Android.

Sure. But I think there are two orthogonal problems:

  1. How to specify alternate platform defaults when cross-compiling.

  2. When we are compiling for an Android platform, which knobs should
     be tweaked by default, and whether there should be a convenience
     "tweak these Android knobs" switch.

The name of the switch in (2) might be related to how (1) is implemented, but it doesn't have to be.

Anyway, this is all getting a bit too theoretical to be productive. I'm not actually cross-compiling, so I don't really know how well or poorly our current Makefile handles it, let alone the autoconf support on top of our Makefile. So without patches to discuss, I think we're just going in circles.

The original poster just wanted knobs for (2). Having (1) would be neat, but I don't see any reason to hold up (2) if nobody is actually working on (1).

-Peff