Re: [PATCHv2] add Android support
Am 19.05.2011 um 08:18 schrieb Junio C Hamano:
> I am still debating myself if this rather huge patch is justifiable, or an
> elaborate joke/hoax. Does anybody seriously want to run git on his phone,
> tablet or set-top box?
>
Well, it has been promoted by the wiki since August 7, 2009 (https://git.wiki.kernel.org/index.php?title=GitFaq&diff=prev&oldid=7982). So you have to change either the wiki or the code. And of course, git is great enough that is has to be run everywhere :-).
> I'd suggest splitting it into three patch series, and justify them
> separately.
>
> (1) Support NO_GECOS_IN_PWENT (Makefile, ident.c);
Done + renamed to NO_GEOCS_IN_PWENT (was NO_PW_GECOS before) as I really like NO_GECOS_IN_PWENT better. Thanks.
> (2) Support NO_GETPASS (Makefile, compat/getpass.c, git-compat-util.h); and
> I wonder if you want to emply the rename trick similar to the one used for
> hstrerror/githstrerror you can see in the git-compat-util.h header file in
> the second step, though.
I've already thought about this but had concerns that gitgetpass will be very near to git_getpass, which already is in connect.c. But I think that's okay and the rename trick will bring more benefits, such as you will be able to use compat/getpass.c as a replacement for a buggy getpass and to test compat/getpass.c on platforms with predefined getpass, too. So, see new patch.
Show 6 quoted lines
> (3) Add uname_S = Android (Makefile).
>
> The first two would become much easier to justify if presented that
> way. At least you won't hear from anybody "we don't want that much code to
> not to run git on a phone!", as it is not entirely implausible to imagine
> environments without support for one or both of these two facilities.
So, you would prefer to leave out ANDROID and use something like "ifeq ($(uname_S),Android)", so you will have to compile using make uname_S=Android? I would be fine with that, too. But I would also be fine with having to specify the build options on the command line or using a config.mak if you want to keep Android out of the Makefile.
Rafael Gieschke <rafael@gieschke.de>