Re: What shall we do with the GECOS field again?

From: Junio C Hamano <junkio@cox.net>
Date: Sep 20, 2005, 07:10 UTC
Message-ID: <7v8xxs5i5x.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050919212113.GB8862@puritan.pnetwork>

Nikolai Weibull <mailing-lists.git@rawuncut.elitemail.org> writes:

> Perhaps something like the following patch will do?,
>         nikolai

Thanks for the patch.  Some nits and requests.

(1) Proper commit log message here, with your Signed-off-by line.

> +	if (!name && !email && getenv("EMAIL")) {
> +		i = copy(buffer, sizeof(buffer), 0, getenv("EMAIL"));
> +		i = add_raw(buffer, sizeof(buffer), i, " ");

(2) Perhaps have `#define IDENT_ENVIRONMENT "EMAIL"' in cache.h
    and use it, like we do for other environment variables.

(3) Probably you need to validate what is in $EMAIL before
    trusting it, so that we can guard ourselves from EMAIL in a
    format that is suitable for other applications but not for
    us?  If you find that the value does not look good, just
    refuse it with an error message to set more specific
    GIT_{AUTHOR,COMMITTER}_* environment variables.

    Unlike GIT_* environment variables, EMAIL is a convention we
    did not invent ourselves.  We cannot expect it to always be
    formatted to our liking, and more importantly, we should not
    demand the user to set it to the way we like -- the other
    application the user originally set EMAIL for might not like
    what we want.