Re: What shall we do with the GECOS field again?
Show 10 quoted lines
> If we stop using GECOS, then can we please start using $EMAIL (or
> perhaps use it regardless of whether we use GECOS or not)? A lot of
> applications seem to look for $EMAIL and I think that it's universal
> enough for git to use it as well. To me it seems that both
> GIT_AUTHOR_NAME, GIT_AUTHOR_EMAIL, GIT_COMMITTER_NAME, and
> GIT_COMMITTER_EMAIL can use it, as I set $EMAIL as
>
> EMAIL="Nikolai Weibull <something@something.something>"
>
> Perhaps I should provide a patch instead of just putting out requests?,
Perhaps something like the following patch will do?,
nikolai---
diff --git a/ident.c b/ident.c
--- a/ident.c
+++ b/ident.c
@@ -127,18 +127,22 @@ char *get_ident(const char *name, const
char date[50];
int i;
- if (!name)
- name = real_name;
- if (!email)
- email = real_email;
+ if (!name && !email && getenv("EMAIL")) {
+ i = copy(buffer, sizeof(buffer), 0, getenv("EMAIL"));
+ i = add_raw(buffer, sizeof(buffer), i, " ");
+ } else {
+ if (!name)
+ name = real_name;
+ if (!email)
+ email = real_email;
+ i = copy(buffer, sizeof(buffer), 0, name);
+ i = add_raw(buffer, sizeof(buffer), i, " <");
+ i = copy(buffer, sizeof(buffer), i, email);
+ i = add_raw(buffer, sizeof(buffer), i, "> ");
+ }
strcpy(date, real_date);
if (date_str)
parse_date(date_str, date, sizeof(date));
-
- i = copy(buffer, sizeof(buffer), 0, name);
- i = add_raw(buffer, sizeof(buffer), i, " <");
- i = copy(buffer, sizeof(buffer), i, email);
- i = add_raw(buffer, sizeof(buffer), i, "> ");
i = copy(buffer, sizeof(buffer), i, date);
if (i >= sizeof(buffer))
die("Impossibly long personal identifier");
--
Nikolai Weibull: now available free of charge at http://bitwi.se/!
Born in Chicago, IL USA; currently residing in Gothenburg, Sweden.
main(){printf(&linux["\021%six\012\0"],(linux)["have"]+"fun"-97);}