Re: ***DONTUSE*** Re: [PATCH] Use a hashtable for objects instead of a sorted list
- From
Junio C Hamano <junkio@cox.net>
- Date
- Feb 12, 2006, 18:34 UTC
- Message-ID
- <7v8xsgbf4v.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0602121822060.21959@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Could it be the shallow thing?
No, I do not think so. In the current "master", "next", "pu" picture, "pu" merges js/obj with the "8856cc69" commit and then shallow and bind comes later. That merged version is what I am testing, and also its second parent, which is "master" plus hashtable. In either case, shallow and bind are not part of the picture.
> Again, sorry for the inconvenience, Junio.
That is not your fault, and I did not mean to sound I am unhappy about *you*. I am indeed unhappy because I did not see anything obviously or subtly wrong with your patch after I moved call to hashtable_index() in find_object().
But I think Linus nailed it. I'll see if I can understand his explanation.