Re: [RFC] use typechange as rename source

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2007, 19:15 UTC
Message-ID: <7v8x4cykkj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071201064916.GA7431@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> And maybe something like this on top for git-status?
>
> diff --git a/wt-status.c b/wt-status.c
> index 0e0439f..e77120d 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -250,6 +250,7 @@ static void wt_status_print_updated(struct wt_status *s)
>  	rev.diffopt.format_callback_data = s;
>  	rev.diffopt.detect_rename = 1;
>  	rev.diffopt.rename_limit = 100;
> +	rev.diffopt.break_opt = 0;
>  	wt_read_cache(s);
>  	run_diff_index(&rev, 1);
>  }

I have to wonder how much this is going to make things worse in the real world, although I agree in the "as we already spend cycles for detect_rename why not" sense.

With the recent change from Alex not to run status when not interactive, it probably does not matter. If we are going to spawn an editor, we are dealing with human interaction and even -B -M should not be too bad.