Re: [RFC] use typechange as rename source

From: Jeff King <peff@peff.net>
Date: Dec 1, 2007, 06:49 UTC
Message-ID: <20071201064916.GA7431@coredump.intra.peff.net>
In-Reply-To: <7vy7ce6hyb.fsf@gitster.siamese.dyndns.org>

On Fri, Nov 30, 2007 at 10:35:08PM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> Sorry for the earlier broken one.  Here is the correct one I wanted to
> send out.
>
> By the way, this breaks some tests in t4008 (break-rewrite test) because
> the test expects the behaviour you found counterintuitive (which was the
> reason we have this thread).

OK, this looks reasonable to me, and it produces diff results (with -B) that make sense for typechanges. Looking at the failing test in t4008, I like the new behavior better.

And maybe something like this on top for git-status?

diff --git a/wt-status.c b/wt-status.c
index 0e0439f..e77120d 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -250,6 +250,7 @@ static void wt_status_print_updated(struct wt_status *s)
 	rev.diffopt.format_callback_data = s;
 	rev.diffopt.detect_rename = 1;
 	rev.diffopt.rename_limit = 100;
+	rev.diffopt.break_opt = 0;
 	wt_read_cache(s);
 	run_diff_index(&rev, 1);
 }