Re: [RFC] use typechange as rename source

From: Jeff King <peff@peff.net>
Date: Nov 30, 2007, 01:57 UTC
Message-ID: <20071130015716.GA15224@coredump.intra.peff.net>
In-Reply-To: <7vmyswsfl6.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 29, 2007 at 05:10:45PM -0800, Junio C Hamano wrote:

Show 11 quoted lines

> > OK. What next? Did the patch I sent make sense? Do you want a cleaned up
> > version with a commit message and signoff, or does it need work?
> 
> It just hit me that breaking (as in diffcore-break) a filepair that is a
> typechange may yield the same result, and if it works, that would be
> conceptually cleaner.  After all, a typechange is the ultimate form of
> total rewriting (the similarity between the preimage and the postimage
> is very low -- even their types are different, let alone contents).
> 
> Compared to that, the rename_used++ in that codepath you touched feels
> more magic to me.

I have always been a bit confused about diffcore-break, so I am probably misunderstanding what you mean. But are you saying that diffcore-break.c:should_break should return 1 for typechanges? If so, that does not have the desired effect.

-Peff