From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 02 Aug 2011 17:01:44 GMT
Subject: Re: [PATCH 3/5] fast-import: check committer name more strictly
Message-ID: <7v8vrbg32f.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1311831844-13123-4-git-send-email-divanorama@gmail.com>

Dmitry Ivankov <divanorama@gmail.com> writes:

> Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
> ---

Please describe how you check this field "more strictly" in the body of
the log message, iow, against what rule you are validating, perhaps
something like:

 The identifier must be either "<address>" or "Name <address>" where
 neither address nor Name can contain '<' nor '>'; otherwise the input
 stream is rejected.

As fast-import is used to _create_ new objects, its input is a simple text
file that can be fixed-up as needed, it is a good idea to validate the
input more strictly and rejecting bad ones.