Re: Bulgarian translation of git

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2012, 08:07 UTC
Message-ID: <7v8vk7gnqf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CANYiYbFYmGNE09fAeHL_uk+0s+yBapTs4BeGch7iCtWR_v9LXQ@mail.gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 7 quoted lines

>> Somebody needs to eyeball this commit before anything else happens on top
>> of it, so that if there is a glaring mistake it can be caught before it
>> spreads to affect work by translators for various languages.
>
> So please check this commit with the updated pot file:
> https://github.com/gotgit/git-po/commit/816049b7ec0e5f452c77a4c4e71e2cb40a0ccb45
> Please note In this commit I removed one line from the 'po/.gitignore' file.

Thanks.

As far as I can tell, this adds git.pot while removes the entry to remove it from po/.gitignore (because now it is a tracked file), but there is no description on how this file was generated in the log message.

Please give a short description to the effect that it was mechanically created by running xgettext on the sources as of b6b3b6a (Update draft release notes to 1.7.10, 2012-02-10), or something like that.

Other than that, I do not immediately see anything objectionable in this commit; I would still appreciate an extra set of eyeballs or two from people who have worked on gitk and/or git-gui i18n/l10n infrastructure in the past, just in case I forgot to check some obvious/trivial gotchas.

I am also Cc'ing people who participated in git-gui and gitk l10n with more than a couple of commits to their po/ part, found by:

    $ cd git-gui/po &&
      git rev-list --parents HEAD . |
      while read commit parent
      do
        git log --pretty=short $parent..$commit^2 -- :/po
      done | git shortlog -n -e

(same for gitk-git)

> As a translater for Chinese, I also made a commit with the translated po file
> 'po/zh_CN.po' in branch master-zh-cn (merged back to master branch).

Thanks.