git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: fix pretty-printing of messages with "\nencoding "

From
Junio C Hamano <junkio@cox.net>
Date
Mar 28, 2007, 22:10 UTC
Message-ID
<7v7it1f29s.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070328215209.GA13672@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I wonder, though, if this function before or after is actually correct;
> if there is no encoding header, we exit the function immediately. But if
> we are changing the encoding from utf8 to a non-utf8 value, we
> presumably should continue and actually insert the new encoding header.

The function is correct; the only reason it may recode to non-utf8 is the user (or Porcelain such as qgit or gitk) explicitly asked to do so -- from the final output they will get the message in user-native encoding and without the extra encoding header, thus we retain the backward compatible behaviour before the re-encoding feature was introduced.

Previous: Jeff KingNext: Jeff King
Message 2 of 3 in “commit: fix pretty-printing of messages with "\nencoding "”
  1. commit: fix pretty-printing of messages with "\nencoding "Jeff King, Mar 28, 2007
  2. Junio C HamanoMar 28, 2007
  3. Jeff KingMar 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.