From: Junio C Hamano <junkio@cox.net>
Date: Wed, 28 Mar 2007 22:10:07 GMT
Subject: Re: [PATCH] commit: fix pretty-printing of messages with "\nencoding "
Message-ID: <7v7it1f29s.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070328215209.GA13672@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I wonder, though, if this function before or after is actually correct;
> if there is no encoding header, we exit the function immediately. But if
> we are changing the encoding from utf8 to a non-utf8 value, we
> presumably should continue and actually insert the new encoding header.

The function is correct; the only reason it may recode to
non-utf8 is the user (or Porcelain such as qgit or gitk)
explicitly asked to do so -- from the final output they will get
the message in user-native encoding and without the extra
encoding header, thus we retain the backward compatible
behaviour before the re-encoding feature was introduced.