git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [NEW REPLACEMENT PATCH] git-checkout: Add a test case for relative paths use.

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 8, 2007, 20:48 UTC
Message-ID
<7v7iks31lm.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<Pine.LNX.4.64.0711081427450.4362@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
>> +	mkdir dir2 &&
>> +	echo bonjour > dir2/file2 &&
>> +	git add dir2/file2 &&
>> +	git commit -m "populate tree"
>> +
>> +'
>
> Please lose the empty line before the closing quote.  (This applies to all 
> tests.)

I personaly find the extra blank lines before and after the indented test body easier to read. That is..

	test_expect_sucess 'test description comes here' '
		test command 1 &&
		test command 2 &&
                ...
                test command N
	'
I agree with all other suggestions from your message.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 4 in “git-checkout: Add a test case for relative paths use.”
  1. git-checkout: Add a test case for relative paths use.David Symonds, Nov 8, 2007
  2. Johannes SchindelinNov 8, 2007
  3. Junio C HamanoNov 8, 2007
  4. Johannes SchindelinNov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.