git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] builtin-fsck: reports missing parent commits

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2008, 07:24 UTC
Message-ID
<7v7igto5vc.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080225071642.GA15761@auto.tuwien.ac.at>
mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
Show 12 quoted lines
> On Sun, Feb 24, 2008 at 07:08:52PM -0800, Junio C Hamano wrote:
> ...
>> So I am not sure what problems in the repository objects these
>> new checks are designed to catch.
>> 
>> This needs a lot of explanation than what's in your commit log
>> message.
>
> If we have already parsed a non-commit object and parse_commit_buffer
> hits such a sha1 in a parent line, it simply drops it (same for grafts).
>
> I hope that you agree with me, that fsck should catch such an error.
See?  That's exactly my point.

You would need to _explain that_ in your commit log message. Who on the list other than you noticed that it is what you are checking?

Previous: Martin Koegler
Message 4 of 4 in “builtin-fsck: reports missing parent commits”
  1. builtin-fsck: reports missing parent commitsMartin Koegler, Feb 24, 2008
  2. Junio C HamanoFeb 25, 2008
  3. Martin KoeglerFeb 25, 2008
  4. Junio C HamanoFeb 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.