Re: [PATCH v3] builtin-fsck: reports missing parent commits

Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:

As far as I can tell, the new test is not testing the commit object we are looking at from the object database. What it is testing is if the code that parsed and prepared the information in "struct commit" found the same number of parents an extra check we are doing here by hand (if not grafted --- but presumably whoever gave the struct commit we are handling here would have obtained that information by doing the same parsing), or the parsing of the graft file (when grafted --- but presumably whoever gave the struct commit we are handling here would have obtained that information by calling the same llokup_commit_graft()).

So I am not sure what problems in the repository objects these new checks are designed to catch.

This needs a lot of explanation than what's in your commit log message.