From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 25 Feb 2008 07:24:55 GMT
Subject: Re: [PATCH v3] builtin-fsck: reports missing parent commits
Message-ID: <7v7igto5vc.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080225071642.GA15761@auto.tuwien.ac.at>

mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:

> On Sun, Feb 24, 2008 at 07:08:52PM -0800, Junio C Hamano wrote:
> ...
>> So I am not sure what problems in the repository objects these
>> new checks are designed to catch.
>> 
>> This needs a lot of explanation than what's in your commit log
>> message.
>
> If we have already parsed a non-commit object and parse_commit_buffer
> hits such a sha1 in a parent line, it simply drops it (same for grafts).
>
> I hope that you agree with me, that fsck should catch such an error.

See?  That's exactly my point.

You would need to _explain that_ in your commit log message.
Who on the list other than you noticed that it is what you are
checking?