git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] diff-index: careful when inspecting work tree items

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2008, 03:12 UTC
Message-ID
<7v7ifjsi2h.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vprtbu45f.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> diff --git a/diff-lib.c b/diff-lib.c
> index 52dbac3..a8e107a 100644
> --- a/diff-lib.c
> +++ b/diff-lib.c
> ...
> @@ -489,8 +516,11 @@ static int get_stat_data(struct cache_entry *ce,
>  	if (!cached) {
>  		int changed;
>  		struct stat st;
> -		if (lstat(ce->name, &st) < 0) {
> -			if (errno == ENOENT && match_missing) {
> +		changed = check_work_tree_entity(ce, &st, NULL);
This "NULL" should be "cbdata->symcache".
Previous: Junio C HamanoNext: Christian Couder
Message 9 of 11 in “Possible d/f conflict bug or regression”
  1. Christian CouderMar 29, 2008
  2. Christian CouderMar 29, 2008
  3. Bryan DonlanMar 30, 2008
  4. Christian CouderMar 30, 2008
  5. Bryan DonlanMar 30, 2008
  6. Junio C HamanoMar 30, 2008
  7. 1/3 Add corner case tests for diff-index and diff-filesJunio C Hamano, Mar 31, 2008
  8. 2/3 diff-index: careful when inspecting work tree itemsJunio C Hamano, Mar 31, 2008
  9. Junio C HamanoMar 31, 2008
  10. Christian CouderMar 31, 2008
  11. 3/3 diff-files: careful when inspecting work tree itemsJunio C Hamano, Mar 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.