Re: [PATCH 2/3] diff-index: careful when inspecting work tree items

From: Christian Couder <chriscool@tuxfamily.org>
Date: Mar 31, 2008, 03:47 UTC
Message-ID: <200803310547.16053.chriscool@tuxfamily.org>
In-Reply-To: <7v7ifjsi2h.fsf@gitster.siamese.dyndns.org>

Le lundi 31 mars 2008, Junio C Hamano a écrit :

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> > diff --git a/diff-lib.c b/diff-lib.c
> > index 52dbac3..a8e107a 100644
> > --- a/diff-lib.c
> > +++ b/diff-lib.c
> > ...
> > @@ -489,8 +516,11 @@ static int get_stat_data(struct cache_entry *ce,
> >  	if (!cached) {
> >  		int changed;
> >  		struct stat st;
> > -		if (lstat(ce->name, &st) < 0) {
> > -			if (errno == ENOENT && match_missing) {
> > +		changed = check_work_tree_entity(ce, &st, NULL);
>
> This "NULL" should be "cbdata->symcache".

Tested-by: Christian Couder <chriscool@tuxfamily.org>

Your patch series works fine for me.

Thanks, Christian.