From: Junio C Hamano Date: Mon, 31 Mar 2008 03:12:06 GMT Subject: Re: [PATCH 2/3] diff-index: careful when inspecting work tree items Message-ID: <7v7ifjsi2h.fsf@gitster.siamese.dyndns.org> In-Reply-To: <7vprtbu45f.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > diff --git a/diff-lib.c b/diff-lib.c > index 52dbac3..a8e107a 100644 > --- a/diff-lib.c > +++ b/diff-lib.c > ... > @@ -489,8 +516,11 @@ static int get_stat_data(struct cache_entry *ce, > if (!cached) { > int changed; > struct stat st; > - if (lstat(ce->name, &st) < 0) { > - if (errno == ENOENT && match_missing) { > + changed = check_work_tree_entity(ce, &st, NULL); This "NULL" should be "cbdata->symcache".