Re: Git global usage and tests

From: Junio C Hamano <gitster@pobox.com>
Date: May 31, 2011, 05:19 UTC
Message-ID: <7v7h97la4s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110530161230.GA25291@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Mon, May 30, 2011 at 06:10:20PM +0200, Romain Geissler wrote:
>
>> > Have you considered pulling the parse-options parser from git into
>> > libgit2? It's one of the more modularized and lib-ified bits of code in
>> > git already.
>> 
>> Yes and No. We have already copied some code from git : parse-option,
>> the error handling functions, a part of the run-command block and a
>> part of the compatibility layer. To my mind, there is no reason to
>> pull it into libgit2 as it's only a client feature that works on
>> strings, and libgit2 does not aim at being a client, only a git
>> library.
>
> Yeah, good point. Definitely it should not be part of the libgit2
> library itself.

IIRC, libgit2 has a lot looser license than ours, and the core GPLv2 part of C git cannot be directly copied without authors' consent; relicensing of necessary parts of C git needs to be arranged.