Re: Git global usage and tests
- From
Jeff King <peff@peff.net>
- Date
- May 30, 2011, 16:12 UTC
- Message-ID
- <20110530161230.GA25291@sigill.intra.peff.net>
- In-Reply-To
- <B369AA28-DEF2-48F3-8E4E-F387E8A57D26@gmail.com>
On Mon, May 30, 2011 at 06:10:20PM +0200, Romain Geissler wrote:
Show 10 quoted lines
> > Have you considered pulling the parse-options parser from git into > > libgit2? It's one of the more modularized and lib-ified bits of code in > > git already. > > Yes and No. We have already copied some code from git : parse-option, > the error handling functions, a part of the run-command block and a > part of the compatibility layer. To my mind, there is no reason to > pull it into libgit2 as it's only a client feature that works on > strings, and libgit2 does not aim at being a client, only a git > library.
Yeah, good point. Definitely it should not be part of the libgit2 library itself.
-Peff