Re: Git global usage and tests
- From
Carlos Martín Nieto <cmn@elego.de>
- Date
- May 31, 2011, 09:05 UTC
- Message-ID
- <20110531090554.GE28708@centaur.lab.cmartin.tk>
- In-Reply-To
- <buor57f78s0.fsf@dhlpc061.dev.necel.com>
On Tue, May 31, 2011 at 02:12:47PM +0900, Miles Bader wrote:
Show 13 quoted lines
> Jeff King <peff@peff.net> writes: > >> Yes and No. We have already copied some code from git : parse-option, > >> the error handling functions, a part of the run-command block and a > >> part of the compatibility layer. To my mind, there is no reason to > >> pull it into libgit2 as it's only a client feature that works on > >> strings, and libgit2 does not aim at being a client, only a git > >> library. > > > > Yeah, good point. Definitely it should not be part of the libgit2 > > library itself. > > But maybe there's room for another library to hold such things > (libgitapp...)?
There are already several libraries to parse command-line options, though IIRC from the last time I used getopt, git's parse-options is more usable. That could be made into a new library (but which should be git-independent)
The git-specific part of figuring out commits and commit ranges could live inside libgit2.
Cheers, cmn
-- Carlos Martín Nieto | http://cmartin.tk "¿Cómo voy a decir bobadas si soy mudo?" -- CACHAI