From: Junio C Hamano Date: Mon, 17 Oct 2011 03:57:52 GMT Subject: Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff. Message-ID: <7v7h44p8vz.fsf@alter.siamese.dyndns.org> In-Reply-To: Kato Kazuyoshi writes: > On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano wrote: >> >> I think a better organization would be >> >>  [1/2] change code so that $diff_class does not have leading SP >>       optionally catch a case where $diff_class stays empty as an error? >> > > I think we don't have to treat empty $diff_class as an error because > $diff_class will be an empty when $line is around modification > (ex. foo or quux). > > foo > - bar > + baz > quuz Ok. then even though class="diff " is not any different from class="diff", I have to say generated html output becomes aesthetically less nice with this change; we may want to do something about it _iff_ it does not take too much change, but as I said I do not care too much about it.