git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: UTF-8 support

From
Junio C Hamano <junkio@cox.net>
Date
Nov 24, 2005, 00:47 UTC
Message-ID
<7v64qi50sw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<1132719301.12227.5.camel@dv>
Pavel Roskin <proski@gnu.org> writes:
> Add gitencoding variable and set it to "utf-8".  Use it for converting
> git-rev-list output.

Sounds good, but is it necessary? Unless I am grossly mistaken, I am opposed to this patch.

When I run gitk with LANG and/or LC_CTYPE set to ja_JP.utf8 (I suspect *whatever*.utf8 would work the same way) on git.git repository, I see Lukas's name (originally in iso8859-1 but my commit objects have it in utf8) and Yoshifuji-san's name (iso2022 converted to utf8) just fine.

And when I run gitk with LANG and/or LC_CTYPE set to ja_JP.ujis (that is another name for EUC-JP) on a toy repository I have commit log messages in EUC-JP (I am not recommending that, just pointing out a possibility), I can see them just fine. In that test repository, setting locale to *.utf8 would not work.

So I suspect your change breaks projects that use local encodings, without fixing or adding anything new.

Previous: Pavel RoskinNext: Paul Mackerras
Message 2 of 8 in “gitk: UTF-8 support”
  1. gitk: UTF-8 supportPavel Roskin, Nov 23, 2005
  2. Junio C HamanoNov 24, 2005
  3. Paul MackerrasNov 24, 2005
  4. Pavel RoskinNov 24, 2005
  5. Junio C HamanoNov 24, 2005
  6. Pavel RoskinNov 24, 2005
  7. Junio C HamanoNov 28, 2005
  8. Pavel RoskinNov 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.