Re: [PATCH] gitk: UTF-8 support
- From
- Pavel Roskin <proski@gnu.org>
- Date
- Nov 24, 2005, 07:12 UTC
- Message-ID
- <20051124021231.nrg8448gk8w4owk8@webmail.spamcop.net>
- In-Reply-To
- <7v1x16y36r.fsf@assigned-by-dhcp.cox.net>
Quoting Junio C Hamano <junkio@cox.net>:
> That is not the point. Point is that I think the user can use > LANG and LC_ALL (I suspect LC_CTYPE is what matters) to get what > you want, and I suspect hardcoding utf8 robs users the > possibility to deal with a repository that uses something else.
Not to argue with you, but it's worth pointing out that git is heavily multiuser software, and interoperability should not be ranked below local configurability.
> And as I suggested in another message (in the died-out thread > about gitweb), we could have i18n.commitEncoding in the > configuration to help gitk and gitweb. I think that is the same > as your "other option".
Yes. Then my patch needs to be changed to set encoding to that setting and only if it's present.
-- Regards, Pavel Roskin