Re: [PATCH] gitk: UTF-8 support

From: Junio C Hamano <junkio@cox.net>
Date: Nov 24, 2005, 06:23 UTC
Message-ID: <7v1x16y36r.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051123235315.oht0zjidc4ccg8gs@webmail.spamcop.net>

Pavel Roskin <proski@gnu.org> writes:

> Then what would you do to work with a repository using utf-8 if the current
> locale is not utf-8?

Obviously the same way as I did to try things out:

	$ LANG=en_US.utf8 DISPLAY=:0 gitk blah

> Anyway, I see your point.  Not ever git repository uses utf-8.  It is not
> enforced by git.

That is not the point. Point is that I think the user can use LANG and LC_ALL (I suspect LC_CTYPE is what matters) to get what you want, and I suspect hardcoding utf8 robs users the possibility to deal with a repository that uses something else.

And as I suggested in another message (in the died-out thread about gitweb), we could have i18n.commitEncoding in the configuration to help gitk and gitweb. I think that is the same as your "other option".