git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] gitweb: Always use git-peek-remote in git_get_references

From
Junio C Hamano <junkio@cox.net>
Date
Sep 20, 2006, 16:09 UTC
Message-ID
<7v64fijz90.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200609191431.49641.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 7 quoted lines
> Instead of trying to read info/refs file, which might not be present
> (we did fallback to git-ls-remote), always use git-peek-remote in
> git_get_references.
>
> It is preparation for git_get_refs_info to also return references
> info. We cannot use info/refs for git_get_refs_info as the information
> contained therein is usually stale.

What the patch does is sane, but I think the last sentence of the proposed log message is not. If info/refs is "usually stale", it is a bug in the repository to have such a stale file.

The real reason for this patch is that a repository served by gitweb is not necessarily meant to be fetched over HTTP and info/refs does not have to be there.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 3 of 9 in “Make git_get_refs_list do work of git_get_references”
  1. 0/2 Make git_get_refs_list do work of git_get_referencesJakub Narebski, Sep 19, 2006
  2. 1/2 gitweb: Always use git-peek-remote in git_get_referencesJakub Narebski, Sep 19, 2006
  3. Junio C HamanoSep 20, 2006
  4. Jakub NarebskiSep 20, 2006
  5. Andreas EricssonSep 21, 2006
  6. 2/2 gitweb: Make git_get_refs_list do work of git_get_referencesJakub Narebski, Sep 19, 2006
  7. Junio C HamanoSep 20, 2006
  8. Jakub NarebskiSep 20, 2006
  9. Junio C HamanoSep 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.