git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitweb: Always use git-peek-remote in git_get_references

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 19, 2006, 12:31 UTC
Message-ID
<200609191431.49641.jnareb@gmail.com>
In-Reply-To
<200609191430.51252.jnareb@gmail.com>

Instead of trying to read info/refs file, which might not be present (we did fallback to git-ls-remote), always use git-peek-remote in git_get_references.

It is preparation for git_get_refs_info to also return references info. We cannot use info/refs for git_get_refs_info as the information contained therein is usually stale.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c77270c..034a88c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -828,16 +828,10 @@ sub git_get_project_owner {
 sub git_get_references {
 	my $type = shift || "";
 	my %refs;
-	my $fd;
 	# 5dc01c595e6c6ec9ccda4f6f69c131c0dd945f8c	refs/tags/v2.6.11
 	# c39ae07f393806ccf406ef966e9a15afc43cc36a	refs/tags/v2.6.11^{}
-	if (-f "$projectroot/$project/info/refs") {
-		open $fd, "$projectroot/$project/info/refs"
-			or return;
-	} else {
-		open $fd, "-|", git_cmd(), "ls-remote", "."
-			or return;
-	}
+	open my $fd, "-|", $GIT, "peek-remote", "$projectroot/$project/"
+		or return;
 
 	while (my $line = <$fd>) {
 		chomp $line;
-- 
1.4.2.1
Previous: Jakub NarebskiNext: Junio C Hamano
Message 2 of 9 in “Make git_get_refs_list do work of git_get_references”
  1. 0/2 Make git_get_refs_list do work of git_get_referencesJakub Narebski, Sep 19, 2006
  2. 1/2 gitweb: Always use git-peek-remote in git_get_referencesJakub Narebski, Sep 19, 2006
  3. Junio C HamanoSep 20, 2006
  4. Jakub NarebskiSep 20, 2006
  5. Andreas EricssonSep 21, 2006
  6. 2/2 gitweb: Make git_get_refs_list do work of git_get_referencesJakub Narebski, Sep 19, 2006
  7. Junio C HamanoSep 20, 2006
  8. Jakub NarebskiSep 20, 2006
  9. Junio C HamanoSep 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.