From: Junio C Hamano <junkio@cox.net>
Date: Wed, 20 Sep 2006 16:09:47 GMT
Subject: Re: [PATCH 1/2] gitweb: Always use git-peek-remote in git_get_references
Message-ID: <7v64fijz90.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200609191431.49641.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Instead of trying to read info/refs file, which might not be present
> (we did fallback to git-ls-remote), always use git-peek-remote in
> git_get_references.
>
> It is preparation for git_get_refs_info to also return references
> info. We cannot use info/refs for git_get_refs_info as the information
> contained therein is usually stale.

What the patch does is sane, but I think the last sentence of
the proposed log message is not.  If info/refs is "usually
stale", it is a bug in the repository to have such a stale file.

The real reason for this patch is that a repository served by
gitweb is not necessarily meant to be fetched over HTTP and
info/refs does not have to be there.