git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Contribute a fairly paranoid update hook

From
Junio C Hamano <junkio@cox.net>
Date
Apr 20, 2007, 17:27 UTC
Message-ID
<7v647ryn0p.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070420145923.GB17480@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 9 quoted lines
> Junio C Hamano <junkio@cox.net> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> 
>> > +$ENV{PATH}     = '/opt/git/bin';
>> 
>> This caught my attention ;-).
>
> What, is replacing PATH in the hook really all that paranoid?
> Its a perfectly reasonable thing to do.  ;-)

I 100% agree it is the right thing to to make sure PATH is a known good value. What caught my attention is /opt/git/bin is the *ONLY* place you need to look at, not even /usr/bin!

Previous: Shawn O. PearceNext: Jakub Narebski
Message 4 of 6 in “Contribute a fairly paranoid update hook”
  1. Contribute a fairly paranoid update hookShawn O. Pearce, Apr 20, 2007
  2. Junio C HamanoApr 20, 2007
  3. Shawn O. PearceApr 20, 2007
  4. Junio C HamanoApr 20, 2007
  5. Jakub NarebskiApr 21, 2007
  6. Shawn O. PearceApr 21, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.