From: Junio C Hamano <junkio@cox.net>
Date: Fri, 20 Apr 2007 17:27:18 GMT
Subject: Re: [PATCH] Contribute a fairly paranoid update hook
Message-ID: <7v647ryn0p.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070420145923.GB17480@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <junkio@cox.net> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> 
>> > +$ENV{PATH}     = '/opt/git/bin';
>> 
>> This caught my attention ;-).
>
> What, is replacing PATH in the hook really all that paranoid?
> Its a perfectly reasonable thing to do.  ;-)

I 100% agree it is the right thing to to make sure PATH is a
known good value.  What caught my attention is /opt/git/bin
is the *ONLY* place you need to look at, not even /usr/bin!