Re: [PATCH] Contribute a fairly paranoid update hook

From: Shawn O. Pearce <spearce@spearce.org>
Date: Apr 20, 2007, 14:59 UTC
Message-ID: <20070420145923.GB17480@spearce.org>
In-Reply-To: <7vmz131fzz.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 5 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > +$ENV{PATH}     = '/opt/git/bin';
> 
> This caught my attention ;-).

What, is replacing PATH in the hook really all that paranoid? Its a perfectly reasonable thing to do. ;-)

Someday I'll post the patch to receive-pack that I use to run it setuid. That thing is also fairly paranoid. I won't submit it for application to git.git though, as I don't think it really belongs in the main receive-pack code. So it might be a patch file for contrib, or just an article in the mailing list archives that people can link to.

I also recently hacked some semi-useful features into gitweb.cgi. I need to finish those for our local use, and then see if I can extract them enough to make them publicly available. gitweb.cgi is probably going to become a cornerstone of our main development and testing workflow, especially for managers and testers who don't want (or really need) full repositories on their deskstops.

-- 
Shawn.