Re: [PATCH 1/3] send-pack: track errors for each ref

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2007, 01:21 UTC
Message-ID: <7v6400z6tk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071118001312.GB4000@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Sat, Nov 17, 2007 at 01:05:35PM -0500, Daniel Barkalow wrote:
>
>> > +		if (ref->nonfastforward) {
>> > +			strcat(quickref, "...");
>> > +			type = '+';
>> > +			msg = " (forced update)";
>> > +		}
>> > +		else {
>> 
>> Coding style, IIRC.
>
> Sorry, I don't see the style nit you're mentioning here.

I think Daniel is referring to "Put 'else' on the same line as the brace that closes the corresponding 'if' opened", iow:

	if (...) {
        	...
	} else {
		...
	}