Re: [PATCH 1/3] send-pack: track errors for each ref

From: Jeff King <peff@peff.net>
Date: Nov 18, 2007, 00:15 UTC
Message-ID: <20071118001509.GC4000@sigill.intra.peff.net>
In-Reply-To: <7v6400twzp.fsf@gitster.siamese.dyndns.org>

On Sat, Nov 17, 2007 at 12:53:14PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > +		strcpy(quickref, status_abbrev(ref->old_sha1));
> > +		if (ref->nonfastforward) {
> > +			strcat(quickref, "...");
> > +			type = '+';
> > +			msg = " (forced update)";
> 
> ... you do not need the " (" and ")" here.

Oops, good catch.

> All merged to 'next'.  Thanks.

I see you fixed up the off-by-one buffer, too. Thanks.

-Peff