Re: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2010, 06:06 UTC
Message-ID: <7v6345ktc1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1270523660.3648.7.camel@mattlaptop2.local>

Matt McCutchen <matt@mattmccutchen.net> writes:

Show 6 quoted lines

> -Wall cleanliness is an intended property of the codebase, so -Wall
> should be on by default even if the user's CFLAGS doesn't include it
> (e.g., the AC_PROG_CC configure test won't include it).
> ---
>
> Thoughts?  Is there a problem with -Wall being GNU-specific?

I think you answered yourself very well.

Show 7 quoted lines

> @@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__
>  # Those must not be GNU-specific; they are shared with perl/ which may
>  # be built by a different compiler. (Note that this is an artifact now
>  # but it still might be nice to keep that distinction.)
> -BASIC_CFLAGS = -I.
> +BASIC_CFLAGS = -Wall -I.
>  BASIC_LDFLAGS =

It still talks about perl/ back from the days when we used to have some .xs stuff, but the principle still should apply.