From: Junio C Hamano Date: Tue, 06 Apr 2010 06:06:54 GMT Subject: Re: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS Message-ID: <7v6345ktc1.fsf@alter.siamese.dyndns.org> In-Reply-To: <1270523660.3648.7.camel@mattlaptop2.local> Matt McCutchen writes: > -Wall cleanliness is an intended property of the codebase, so -Wall > should be on by default even if the user's CFLAGS doesn't include it > (e.g., the AC_PROG_CC configure test won't include it). > --- > > Thoughts? Is there a problem with -Wall being GNU-specific? I think you answered yourself very well. > @@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ > # Those must not be GNU-specific; they are shared with perl/ which may > # be built by a different compiler. (Note that this is an artifact now > # but it still might be nice to keep that distinction.) > -BASIC_CFLAGS = -I. > +BASIC_CFLAGS = -Wall -I. > BASIC_LDFLAGS = It still talks about perl/ back from the days when we used to have some .xs stuff, but the principle still should apply.