threads / patch / 23350

patchMakefile: move -Wall from CFLAGS to BASIC_CFLAGS

Subject: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS

## tl;dr

2 messages between Apr 6, 2010 and Apr 6, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Matt McCutchen· Apr 6, 2010, 03:14 UTC · lore

-Wall cleanliness is an intended property of the codebase, so -Wall should be on by default even if the user's CFLAGS doesn't include it (e.g., the AC_PROG_CC configure test won't include it). ---

Thoughts?  Is there a problem with -Wall being GNU-specific?

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to Makefile +2 −2

diff --git a/Makefile b/Makefile
index 7c616f8..88f9b47 100644
--- a/Makefile
+++ b/Makefile
@@ -241,7 +241,7 @@ endif
 
 # CFLAGS and LDFLAGS are for the users to override from the command line.
 
-CFLAGS = -g -O2 -Wall
+CFLAGS = -g -O2
 LDFLAGS =
 ALL_CFLAGS = $(CFLAGS)
 ALL_LDFLAGS = $(LDFLAGS)
@@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__
 # Those must not be GNU-specific; they are shared with perl/ which may
 # be built by a different compiler. (Note that this is an artifact now
 # but it still might be nice to keep that distinction.)
-BASIC_CFLAGS = -I.
+BASIC_CFLAGS = -Wall -I.
 BASIC_LDFLAGS =
 
 # Guard against environment variables

-- 
1.7.0.2.288.gb0894e

Junio C Hamano· Apr 6, 2010, 06:06 UTC · re: Matt McCutchen · lore

Re: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS

Matt McCutchen <matt@mattmccutchen.net> writes:

Show 6 quoted lines

> -Wall cleanliness is an intended property of the codebase, so -Wall
> should be on by default even if the user's CFLAGS doesn't include it
> (e.g., the AC_PROG_CC configure test won't include it).
> ---
>
> Thoughts?  Is there a problem with -Wall being GNU-specific?

I think you answered yourself very well.

Show 7 quoted lines

> @@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__
>  # Those must not be GNU-specific; they are shared with perl/ which may
>  # be built by a different compiler. (Note that this is an artifact now
>  # but it still might be nice to keep that distinction.)
> -BASIC_CFLAGS = -I.
> +BASIC_CFLAGS = -Wall -I.
>  BASIC_LDFLAGS =

It still talks about perl/ back from the days when we used to have some .xs stuff, but the principle still should apply.