Re: Possible regression in ref advertisement
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 26, 2013, 15:46 UTC
- Message-ID
- <7v621fnkma.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1361891069.9005.11.camel@flaca.cmartin.tk>
Carlos Martín Nieto <cmn@elego.de> writes:
Show 5 quoted lines
> Since the libgit2 parser seems to work with it, it's perfectly possible > I did mess about with the file and then promptly forgot. An error would > definitely not help here, but I do think a warning should be issued if > the file isn't quite as it should be. It seems the parser can already > detect this, so it could be as easy as adding a fprintf(stderr, "...").
Yeah, another thing that may be worth checking is if this was written/corrupted by hand, in which case there is no need to worry about it further, or by something else, e.g. reimplementations such as jgit and libgit2, or a third-party tool that wants to be compatible with Git, in which case we do want to see that get fixed.