git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Possible regression in ref advertisement

From
Carlos Martín Nieto <cmn@elego.de>
Date
Feb 25, 2013, 19:18 UTC
Message-ID
<1361819916.24515.5.camel@centaur.cmartin.tk>
In-Reply-To
<7vvc9gxn2y.fsf@alter.siamese.dyndns.org>
On Mon, 2013-02-25 at 10:31 -0800, Junio C Hamano wrote:
Show 33 quoted lines
> Carlos Martín Nieto <cmn@elego.de> writes:
> 
> > Hi all,
> >
> > When testing to see if a different implementation was in shape, I came
> > across something odd where newer git doesn't advertise one of the refs
> > in the git repo.
> >
> > Running `git ls-remote .` or `git-upload-pack` in my git repo, newer git
> > versions omit peeling the v1.8.0-rc3 tag.
> >
> > The diff between the command above when ran with 1.7.10.4 (from Debian)
> > and current 'master'
> >
> > --- old 2013-02-25 17:31:29.583526606 +0100
> > +++ new 2013-02-25 17:31:36.783526559 +0100
> > @@ -1379,7 +1379,6 @@
> >  c15295d7477ccec489953299bd03a8e62f86e611       refs/tags/v1.8.0-rc2
> >  cd46259ebf2e624bcee2aaae05c36663d414e1a2       refs/tags/v1.8.0-rc2^{}
> >  22ed067acc84eac8a0a72d20478a18aee4e25571       refs/tags/v1.8.0-rc3
> > -87a5461fa7b30f7b7baf27204f10219d61500fbf       refs/tags/v1.8.0-rc3^{}
> >  bfeb8b9ae0012cb61e026cbcd29664876abf5389       refs/tags/v1.8.0.1
> >  ed9fe755130891fc878bb2433204faffb534697b       refs/tags/v1.8.0.1^{}
> >  63add1fb45e1ab7a76bb38bbb9467c91fdfaaa7e       refs/tags/v1.8.0.2
> >
> > Diffing with the output from next, diff tells me it's binary for some
> > reason, but looking manually, the peeled v1.8.0-rc3 tag isn't there
> > either. I haven't had time to bisect this, so I'm putting it out there
> > in case anybody wants to investigate before I have time to dig into it.
> 
> Interesting.  "git ls-remote . | grep 1.8.0-" for maint, master,
> next and pu produce identical results for me, all showing peeled
> ones correctly.

Bisection leads me to Peff's 435c8332 (2012-10-04; upload-pack: use peel_ref for ref advertisements) and reverting that commit brings the -rc3^{} back.

   cmn
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 10 in “Possible regression in ref advertisement”
  1. Carlos Martín NietoFeb 25, 2013
  2. Junio C HamanoFeb 25, 2013
  3. Carlos Martín NietoFeb 25, 2013
  4. Junio C HamanoFeb 25, 2013
  5. Carlos Martín NietoFeb 25, 2013
  6. Junio C HamanoFeb 25, 2013
  7. Carlos Martín NietoFeb 25, 2013
  8. Junio C HamanoFeb 25, 2013
  9. Carlos Martín NietoFeb 26, 2013
  10. Junio C HamanoFeb 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.