git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_file: introduce close_one_pack() to close packs on fd pressure

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 30, 2013, 15:39 UTC
Message-ID
<7v61vsxdiz.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1375157113-608-1-git-send-email-bcasey@nvidia.com>
Brandon Casey <bcasey@nvidia.com> writes:
Show 10 quoted lines
> From: Brandon Casey <drafnel@gmail.com>
>
> When the number of open packs exceeds pack_max_fds, unuse_one_window()
> is called repeatedly to attempt to release the least-recently-used
> pack windows, which, as a side-effect, will also close a pack file
> after closing its last open window.  If a pack file has been opened,
> but no windows have been allocated into it, it will never be selected
> by unuse_one_window() and hence its file descriptor will not be
> closed.  When this happens, git may exceed the number of file
> descriptors permitted by the system.
An interesting find.  The patch from a cursory look reads OK.
Thanks.
> This is not likely to occur during upload-pack since upload-pack
> reads each object from the pack so that it can peel tags and
> advertise the exposed object.

Another interesting find. Perhaps there is a room for improvements, as packed-refs file knows what objects the tags peel to? I vaguely recall Peff was actively reducing the object access during ref enumeration in not so distant past...

Previous: Eric SunshineNext: Jeff King
Message 3 of 23 in “sha1_file: introduce close_one_pack() to close packs on fd pressure”
  1. sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Jul 30, 2013
  2. Eric SunshineJul 30, 2013
  3. Junio C HamanoJul 30, 2013
  4. Jeff KingJul 30, 2013
  5. Brandon CaseyJul 30, 2013
  6. 1/2 sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Jul 31, 2013
  7. 2/2 Don't close pack fd when free'ing pack windowsBrandon Casey, Jul 31, 2013
  8. Antoine PelisseJul 31, 2013
  9. Fredrik GustafssonJul 31, 2013
  10. Brandon CaseyJul 31, 2013
  11. Fredrik GustafssonJul 31, 2013
  12. Brandon CaseyJul 31, 2013
  13. Thomas RastJul 31, 2013
  14. Junio C HamanoAug 1, 2013
  15. Brandon CaseyAug 1, 2013
  16. Junio C HamanoAug 1, 2013
  17. Brandon CaseyAug 1, 2013
  18. Brandon CaseyAug 1, 2013
  19. Junio C HamanoAug 1, 2013
  20. Brandon CaseyAug 1, 2013
  21. sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Aug 2, 2013
  22. Junio C HamanoAug 2, 2013
  23. Brandon CaseyAug 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.