git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] sha1_file: introduce close_one_pack() to close packs on fd pressure

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 1, 2013, 18:39 UTC
Message-ID
<7v4nb9s1az.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CA+sFfMdp9j4LL4eocbsJu5DCEfhoE=uEN_wJ3o8VBW+hUVFVLQ@mail.gmail.com>
Brandon Casey <drafnel@gmail.com> writes:
Show 7 quoted lines
> I've been looking closer at uses of p->windows everywhere, and it
> seems that we always open_packed_git() before we try to create new
> windows.  There doesn't seem to be any reason that we can't continue
> to use the existing open windows even after closing the pack file.
> ...
> If we don't need to close_pack_windows(), find_lru_pack() doesn't
> strictly need to reject packs that have windows in use.

That makes me feel somewhat uneasy. Yes, you can open/mmap/close and hold onto the contents of a file still mapped in-core, and it may not count as "open filedescriptor", but do OSes allow infinite such mmapped regions to us? We do keep track of number of open windows, but is there a way for us to learn how close we are to the limit?

Previous: Brandon CaseyNext: Brandon Casey
Message 16 of 23 in “sha1_file: introduce close_one_pack() to close packs on fd pressure”
  1. sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Jul 30, 2013
  2. Eric SunshineJul 30, 2013
  3. Junio C HamanoJul 30, 2013
  4. Jeff KingJul 30, 2013
  5. Brandon CaseyJul 30, 2013
  6. 1/2 sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Jul 31, 2013
  7. 2/2 Don't close pack fd when free'ing pack windowsBrandon Casey, Jul 31, 2013
  8. Antoine PelisseJul 31, 2013
  9. Fredrik GustafssonJul 31, 2013
  10. Brandon CaseyJul 31, 2013
  11. Fredrik GustafssonJul 31, 2013
  12. Brandon CaseyJul 31, 2013
  13. Thomas RastJul 31, 2013
  14. Junio C HamanoAug 1, 2013
  15. Brandon CaseyAug 1, 2013
  16. Junio C HamanoAug 1, 2013
  17. Brandon CaseyAug 1, 2013
  18. Brandon CaseyAug 1, 2013
  19. Junio C HamanoAug 1, 2013
  20. Brandon CaseyAug 1, 2013
  21. sha1_file: introduce close_one_pack() to close packs on fd pressureBrandon Casey, Aug 2, 2013
  22. Junio C HamanoAug 2, 2013
  23. Brandon CaseyAug 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.